Skip to content

[codex] Fix ACL typing and MGM/QDB versions#31

Merged
lobis merged 5 commits into
mainfrom
codex/acl-edit-typing-r
May 12, 2026
Merged

[codex] Fix ACL typing and MGM/QDB versions#31
lobis merged 5 commits into
mainfrom
codex/acl-edit-typing-r

Conversation

@lobis
Copy link
Copy Markdown
Collaborator

@lobis lobis commented May 12, 2026

Summary

  • stop intercepting r while editing namespace attribute values
  • keep recursive toggling on r in the attribute key-selection stage and clarify the input-stage hint
  • show full MGM/QDB EOS build versions when available, using cheap RPM metadata first
  • ignore SSH warning/banner noise while parsing RPM version output
  • fall back to eos version, then eos --version, and keep raft-info as the QDB last resort
  • size the MGM/QDB version column from content while keeping the table spread across wide terminals

Validation

  • go test ./eos -run 'TestParseEOSServerPackageVersion|TestEOSVersionOnHostUsesPackageVersionFirst|TestQDBVersionOnHostUsesEOSBuildVersion'\n- go test ./eos -run 'Test(ParseEOSServerBuildVersionIncludesRelease|ParseEOSServerPackageVersionStripsRPMPlatformSuffix|EOSVersionOnHostUsesPackageVersionFirst|EOSVersionOnHostFallsBackToEOSVersion|EOSVersionOnHostFallsBackToDashVersion|QDBVersionOnHostUsesEOSBuildVersion)'\n- go test ./ui -run 'TestUnifiedMGMViewShowsFullBuildVersions|TestUnifiedMGMViewKeepsVersionColumnAtRightEdge|TestUnifiedMGMViewShowsQDBColumns'\n- go test ./...\n- go build ./...\n\n## Notes\n- Verified on eospilot that eos version works on the MGM leader but can fail on follower/non-master hosts, while RPM metadata still exposes the full build release.

@lobis lobis marked this pull request as ready for review May 12, 2026 09:13
@lobis lobis changed the title [codex] Fix ACL attribute value typing [codex] Fix ACL typing and MGM/QDB versions May 12, 2026
@lobis lobis merged commit 61e00c9 into main May 12, 2026
4 checks passed
@lobis lobis deleted the codex/acl-edit-typing-r branch May 12, 2026 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant