Skip to content

Remove dependency to cerpus/coreclient#2344

Merged
emmachughes merged 2 commits intomasterfrom
1005-ca-should-no-longer-use-cerpuscoreclient
Jun 15, 2023
Merged

Remove dependency to cerpus/coreclient#2344
emmachughes merged 2 commits intomasterfrom
1005-ca-should-no-longer-use-cerpuscoreclient

Conversation

@emmachughes
Copy link
Contributor

Core is long gone, but we still used data objects from its client library. To ease the maintenance burden, these are copied to CA and the client library removed.

@emmachughes emmachughes requested a review from chrieinv June 14, 2023 12:50
@emmachughes emmachughes linked an issue Jun 14, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

Merging #2344 (8724d02) into master (7301659) will increase coverage by 0.03%.
The diff coverage is 68.42%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2344      +/-   ##
============================================
+ Coverage     56.17%   56.20%   +0.03%     
- Complexity     2765     2779      +14     
============================================
  Files           287      290       +3     
  Lines         12383    12419      +36     
============================================
+ Hits           6956     6980      +24     
- Misses         5427     5439      +12     
Components Coverage Δ
contentauthor 56.20% <68.42%> (+0.03%) ⬆️

@emmachughes emmachughes merged commit 8a2e339 into master Jun 15, 2023
@emmachughes emmachughes deleted the 1005-ca-should-no-longer-use-cerpuscoreclient branch June 15, 2023 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CA should no longer use cerpus/coreclient

2 participants