GH #2385: Missing Wiris config caused CKEditor crash in create/edit NDLA mode#2386
Merged
GH #2385: Missing Wiris config caused CKEditor crash in create/edit NDLA mode#2386
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2386 +/- ##
============================================
+ Coverage 59.31% 60.30% +0.99%
- Complexity 2780 2782 +2
============================================
Files 290 290
Lines 12555 12562 +7
============================================
+ Hits 7447 7576 +129
+ Misses 5108 4986 -122
|
…us/Edlib into 2385-unable-to-load-ckeditor-in-h5p
emmachughes
reviewed
Jul 6, 2023
sourcecode/apis/contentauthor/app/Libraries/H5P/H5PConfigAbstract.php
Outdated
Show resolved
Hide resolved
emmachughes
approved these changes
Jul 6, 2023
ssethupathy
approved these changes
Jul 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.