Support editing via LTI Deep Linking in Content Author#2578
Merged
emmachughes merged 4 commits intomasterfrom Nov 2, 2023
Merged
Support editing via LTI Deep Linking in Content Author#2578emmachughes merged 4 commits intomasterfrom
emmachughes merged 4 commits intomasterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2578 +/- ##
============================================
- Coverage 62.78% 62.67% -0.12%
- Complexity 2737 2738 +1
============================================
Files 279 280 +1
Lines 12146 12145 -1
============================================
- Hits 7626 7612 -14
- Misses 4520 4533 +13
|
chrieinv
approved these changes
Oct 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds editing support via LTI Deep Linking. It works by checking if content is launched via a Deep Linking request, and if so, redirects to the editor.
Contained in a separate commit is some refactoring of LTI handling in CA. The big changes are:
App\Http\Requests\LTIRequest::fromRequest()is removed. This didn't verify that the LTI request was signed, yet was used "everywhere".App\Lti\Lti::getRequest()is the intended replacement.App\H5pLtiis renamed toApp\Lti\Lti. This had nothing to do with H5P anyway.App\Http\Requests\LTIRequestis renamed toApp\Lti\LtiRequest.App\H5pLti::getValidatedLtiRequest()is nowApp\Lti\Lti::getRequest(), and takes Laravel's request object as its param.The justification for these changes: