GH #2589: CA Admin: Allow updating library translations in database#2619
Merged
GH #2589: CA Admin: Allow updating library translations in database#2619
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2619 +/- ##
============================================
+ Coverage 65.08% 65.26% +0.18%
- Complexity 2731 2741 +10
============================================
Files 278 279 +1
Lines 12128 12191 +63
============================================
+ Hits 7894 7957 +63
Misses 4234 4234
|
….com:cerpus/Edlib into 2589-update-language-files-for-h5p-libraries
…ion and empty translation. Disable upload for non existing translation
emmachughes
reviewed
Nov 23, 2023
sourcecode/apis/contentauthor/app/Http/Controllers/Admin/AdminH5PDetailsController.php
Outdated
Show resolved
Hide resolved
emmachughes
approved these changes
Nov 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow editing the existing translations stored in the database for H5P content types and libraries