use less non-standard laravel config#2644
Merged
emmachughes merged 1 commit intomasterfrom Dec 13, 2023
Merged
Conversation
emmachughes
commented
Dec 13, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2644 +/- ##
=========================================
Coverage 66.95% 66.95%
Complexity 2659 2659
=========================================
Files 269 269
Lines 11840 11840
=========================================
Hits 7928 7928
Misses 3912 3912
|
chrieinv
approved these changes
Dec 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vapor uses Laravel's naming convention for database variables, e.g.
DB_HOST, so CA needs to recognise these. TheEDLIBCOMMON_stuff was misguided and should be removed after we shut down k8s, but CA will keep supporting them for now.While we're at it, we do some minor cleanup to bring the configuration closer to the Laravel skeleton application's defaults.