remove ContentTypes stuff, fix bad redirect after adapter change#2771
Merged
emmachughes merged 2 commits intomasterfrom Oct 2, 2024
Merged
remove ContentTypes stuff, fix bad redirect after adapter change#2771emmachughes merged 2 commits intomasterfrom
emmachughes merged 2 commits intomasterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2771 +/- ##
============================================
+ Coverage 69.67% 70.80% +1.12%
+ Complexity 2700 2671 -29
============================================
Files 272 263 -9
Lines 11536 11353 -183
============================================
Hits 8038 8038
+ Misses 3498 3315 -183
|
chrieinv
approved these changes
Sep 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discovered while working on #2768
CA has a handful of classes that implement
ContentTypesInterface. These are only used by/create/{contenttype?}/ContentController, which only gathers some data and then tries to render a non-existent view. This removes that route, controller, all the implementations ofContentTypesInterface, and the translations used exclusively by them.Since the adapter switching controller redirects to that route (and results in an error), it is changed to return nothing, and the JS code is altered to just reload the page.