Skip to content

CA: Adjust paths for php-cs-fixer#2910

Merged
chrieinv merged 1 commit intomasterfrom
adjust-php-cs-fixer-paths
Jan 17, 2025
Merged

CA: Adjust paths for php-cs-fixer#2910
chrieinv merged 1 commit intomasterfrom
adjust-php-cs-fixer-paths

Conversation

@chrieinv
Copy link
Contributor

@chrieinv chrieinv commented Jan 13, 2025

When run from command line php-cs-fixer fails when trying to access a folder in storage/app that it doesn't have access to.
This adjusts the paths that php-cs-fixer checks.

The original config used path() to add folders, this function includes files/folders that contains the provided string in the path.
So ->path('app') would include all files in the app folder but also any other file/folder containing the string app, e.g. /storage/app/ and the file public/js/h5p/ckeditor_wiris/integration/lib/com/wiris/system/CallWrapper.class.php (the filename contains 'app')

@github-actions github-actions bot added the Component: Content Author All issues that affect content author (sourcecode/apis/contentauthor) label Jan 13, 2025
@chrieinv chrieinv requested a review from emmachughes January 13, 2025 14:08
@chrieinv chrieinv merged commit 02ac244 into master Jan 17, 2025
6 checks passed
@chrieinv chrieinv deleted the adjust-php-cs-fixer-paths branch January 17, 2025 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: Content Author All issues that affect content author (sourcecode/apis/contentauthor)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants