fix(inspect): close CRL response body on io.ReadAll error path

[SAY-5]

Closes #442.

Bug

`checkCRLValidCert` in `pkg/inspect/secret/util.go` closed `resp.Body` only on the success path:

```go
resp, err := http.DefaultClient.Do(req)
if err != nil {
return false, fmt.Errorf("error getting HTTP response: %w", err)
}

body, err := io.ReadAll(resp.Body)
if err != nil {
return false, fmt.Errorf("error reading HTTP body: %w", err) // ← body leaked
}
resp.Body.Close()
```

Any time `io.ReadAll` returned a non-nil error (truncated response, transport reset, peer TLS close, etc.) the function returned early and the underlying TCP connection was leaked. `bodyclose` doesn't catch this class of bug because the analyzer treats the body as handled as long as `Close` appears anywhere in the function, without verifying reachability from every error-return — same gap as the upstream `httpresponse` analyzer (golang/go#75902).

Fix

One-line edit: add `defer resp.Body.Close()` immediately after the successful `http.Do()` and drop the explicit post-read call. The body is now closed from every return site.

Testing

• `go build ./...` — clean.
• `go vet ./...` — clean.
• `go test ./pkg/inspect/secret/...` — one unrelated pre-existing failure in `Test_describeTrusted` (a macOS/Go cert-string drift: `certificate is not trusted` vs `signed by unknown authority`) which is not touched by this PR and reproduces on `main` before the change.

Signed-off-by: SAY-5 SAY-5@users.noreply.github.com

[cert-manager-prow]

Hi @SAY-5. Thanks for your PR.

I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[erikgb]

/ok-to-test

[Copilot]

Pull request overview

Fixes an HTTP response body leak in checkCRLValidCert so the CRL fetch connection is closed even when io.ReadAll fails (addressing #442).

Changes:

• Add defer resp.Body.Close() immediately after a successful http.DefaultClient.Do(req).
• Remove the explicit resp.Body.Close() call that only ran on the success path.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[erikgb]

Thanks @SAY-5! 🚀

/lgtm
/approve

[cert-manager-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: erikgb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [erikgb]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment