Skip to content

BUGFIX: size was not re-calculated#9

Merged
cert-manager-prow[bot] merged 1 commit intomainfrom
bugfix_incorrect_size
May 14, 2025
Merged

BUGFIX: size was not re-calculated#9
cert-manager-prow[bot] merged 1 commit intomainfrom
bugfix_incorrect_size

Conversation

@inteon
Copy link
Copy Markdown
Member

@inteon inteon commented May 14, 2025

Did not cause any issues when testing with docker, but caused kubernetes to fail!

Failed to pull image "...": rpc error: code = FailedPrecondition desc = failed to pull and unpack image "...": failed commit on ref "manifest-sha256:50c9a7a9ad1c8e2985d75a830f213820360bbd792ef66afe498e21e6307680dc": "manifest-sha256:50c9a7a9ad1c8e2985d75a830f213820360bbd792ef66afe498e21e6307680dc" failed size validation: 1643 != 1200: failed precondition

The size of the modified manifest was not re-calculated, causing the reference to contain an incorrect size.

Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
@cert-manager-prow cert-manager-prow Bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 14, 2025
@inteon
Copy link
Copy Markdown
Member Author

inteon commented May 14, 2025

/approve
/lgtm

@cert-manager-prow
Copy link
Copy Markdown
Contributor

@inteon: you cannot LGTM your own PR.

Details

In response to this:

/approve
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@cert-manager-prow
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 14, 2025
@inteon inteon added the lgtm Indicates that a PR is ready to be merged. label May 14, 2025
@cert-manager-prow cert-manager-prow Bot merged commit a79b7f0 into main May 14, 2025
5 checks passed
@erikgb erikgb deleted the bugfix_incorrect_size branch September 14, 2025 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant