Skip to content

Limit self-upgrade to cert-manager org#185

Merged
cert-manager-prow[bot] merged 1 commit intocert-manager:mainfrom
jsoref:limit-self-upgrade-to-cert-manager-org
Aug 23, 2024
Merged

Limit self-upgrade to cert-manager org#185
cert-manager-prow[bot] merged 1 commit intocert-manager:mainfrom
jsoref:limit-self-upgrade-to-cert-manager-org

Conversation

@jsoref
Copy link
Copy Markdown
Contributor

@jsoref jsoref commented Aug 23, 2024

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@cert-manager-prow cert-manager-prow Bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 23, 2024
@inteon
Copy link
Copy Markdown
Member

inteon commented Aug 23, 2024

After merging this PR, we will have to manually run make upgrade-klone in all the projects that use makefile modules.
This is due to a limitation of the self-upgrade script, GitHub actions cannot make PRs that change the GitHub action contents.

@inteon
Copy link
Copy Markdown
Member

inteon commented Aug 23, 2024

/approve
/lgtm

@cert-manager-prow cert-manager-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 23, 2024
@cert-manager-prow
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 23, 2024
@cert-manager-prow cert-manager-prow Bot merged commit 922050c into cert-manager:main Aug 23, 2024
@jsoref jsoref deleted the limit-self-upgrade-to-cert-manager-org branch August 23, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

make-self-upgrade.yaml doesn't work on constrained repositories

2 participants