Skip to content

Bump tools versions to their latest releases#319

Merged
cert-manager-prow[bot] merged 2 commits into
cert-manager:mainfrom
erikgb:bump-tools-2
Aug 10, 2025
Merged

Bump tools versions to their latest releases#319
cert-manager-prow[bot] merged 2 commits into
cert-manager:mainfrom
erikgb:bump-tools-2

Conversation

@erikgb
Copy link
Copy Markdown
Member

@erikgb erikgb commented Aug 10, 2025

@hjoshi123, this is a great example where Renovate could help! Maybe you can take a look at this after cert-manager/cert-manager#7905 is in?

Signed-off-by: Erik Godding Boye <egboye@gmail.com>
@cert-manager-prow cert-manager-prow Bot added the dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. label Aug 10, 2025
@erikgb erikgb requested a review from ThatsMrTalbot August 10, 2025 11:08
@cert-manager-prow cert-manager-prow Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 10, 2025
@erikgb erikgb requested a review from inteon August 10, 2025 11:09
@erikgb
Copy link
Copy Markdown
Member Author

erikgb commented Aug 10, 2025

@inteon @ThatsMrTalbot Maybe one of you could run make learn-tools-shas and commit the result? Our (Palo Alto) FW is just messing up everything from my workstation: 🤯

[info]: downloaded /tmp/tmp.O1V3zW0Tzj/_bin/learn/download/tools/operator-sdk@v1.41.1_linux_amd64
curl: (56) Recv failure: Connection reset by peer
make[1]: *** [tools/00_mod.mk:607: /tmp/tmp.O1V3zW0Tzj/_bin/learn/download/tools/istioctl@1.26.3_linux_amd64] Error 56
make[1]: *** Waiting for unfinished jobs....
curl: (56) Recv failure: Connection reset by peer
make[1]: *** [tools/00_mod.mk:578: /tmp/tmp.O1V3zW0Tzj/_bin/learn/download/tools/ytt@v0.52.0_linux_amd64] Error 56
curl: (56) Recv failure: Connection reset by peer
curl: (56) Recv failure: Connection reset by peer
make[1]: *** [tools/00_mod.mk:467: /tmp/tmp.O1V3zW0Tzj/_bin/learn/download/tools/azwi@v1.5.1_linux_amd64] Error 56
make[1]: *** [tools/00_mod.mk:500: /tmp/tmp.O1V3zW0Tzj/_bin/learn/download/tools/kyverno@v1.15.0_linux_amd64] Error 56
curl: (56) Recv failure: Connection reset by peer
make[1]: *** [tools/00_mod.mk:563: /tmp/tmp.O1V3zW0Tzj/_bin/learn/download/tools/trivy@v0.65.0_linux_amd64] Error 56
curl: (56) Recv failure: Connection reset by peer
make[1]: *** [tools/00_mod.mk:622: /tmp/tmp.O1V3zW0Tzj/_bin/learn/download/tools/preflight@1.14.0_linux_amd64] Error 56
curl: (56) Recv failure: Connection reset by peer
make[1]: *** [tools/00_mod.mk:429: /tmp/tmp.O1V3zW0Tzj/_bin/learn/download/tools/kubectl@v1.33.3_linux_amd64] Error 56
curl: (56) Recv failure: Connection reset by peer
make[1]: *** [tools/00_mod.mk:529: /tmp/tmp.O1V3zW0Tzj/_bin/learn/download/tools/ko@0.18.0_linux_amd64] Error 56

@hjoshi123
Copy link
Copy Markdown
Contributor

@hjoshi123, this is a great example where Renovate could help! Maybe you can take a look at this after cert-manager/cert-manager#7905 is in?

Yes @erikgb once the config is set and tested in the cert manager repo we can move the config to makefile modules so all repository can get it. The config might be different for each repo but it will be in one place.

@cert-manager-prow cert-manager-prow Bot added dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 10, 2025
Signed-off-by: Adam Talbot <adamtalbot93@googlemail.com>
@cert-manager-prow cert-manager-prow Bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. and removed dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. labels Aug 10, 2025
@ThatsMrTalbot
Copy link
Copy Markdown
Contributor

Yes @erikgb once the config is set and tested in the cert manager repo we can move the config to makefile modules so all repository can get it. The config might be different for each repo but it will be in one place.

Since these versions are managed centrally - I would not have the individual repos updating them it would conflict with the upstream makefile-modules. I would have renovate run in this repo to update these tools and we already have tooling to push out changes to makefile-modules everywhere

@erikgb
Copy link
Copy Markdown
Member Author

erikgb commented Aug 10, 2025

Since these versions are managed centrally - I would not have the individual repos updating them it would conflict with the upstream makefile-modules. I would have renovate run in this repo to update these tools and we already have tooling to push out changes to makefile-modules everywhere

Indeed! That's what I meant. These versions should be managed and renovated in this project (only).

Thanks for "learning the shas", @ThatsMrTalbot. I think this PR should be good to go now.

@ThatsMrTalbot
Copy link
Copy Markdown
Contributor

/lgtm

@cert-manager-prow cert-manager-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 10, 2025
@erikgb
Copy link
Copy Markdown
Member Author

erikgb commented Aug 10, 2025

/approve

@cert-manager-prow
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: erikgb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 10, 2025
@cert-manager-prow cert-manager-prow Bot merged commit 46c5dc8 into cert-manager:main Aug 10, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants