Fix installation of envTest#103
Merged
cert-manager-prow[bot] merged 1 commit intocert-manager:masterfrom Feb 17, 2026
Merged
Conversation
8688344 to
8aba2b2
Compare
Member
Author
|
/cc @SgtCoDFish |
8b6f56d to
b8f8a45
Compare
Signed-off-by: Erik Godding Boye <egboye@gmail.com>
b8f8a45 to
ce87fbf
Compare
SgtCoDFish
approved these changes
Feb 17, 2026
Member
SgtCoDFish
left a comment
There was a problem hiding this comment.
/lgtm
/approve
Looks good from a quick glance!
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SgtCoDFish The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous download location, https://go.kubebuilder.io/test-tools, is no longer available. This can be seen in the currently failing PR: #102.
I didn't want to spend a lot of time fixing this, so I just ripped some code from the kubebuilder testdata setup in https://github.com/kubernetes-sigs/kubebuilder/blob/59b97dd38d0f6c3f2b5e05f3d4767bd0be6b9fb3/testdata/project-v4/Makefile. The code looks awful, but it appears to work. 😅