Skip to content

Fix installation of envTest#103

Merged
cert-manager-prow[bot] merged 1 commit intocert-manager:masterfrom
erikgb:fix-envtest-install
Feb 17, 2026
Merged

Fix installation of envTest#103
cert-manager-prow[bot] merged 1 commit intocert-manager:masterfrom
erikgb:fix-envtest-install

Conversation

@erikgb
Copy link
Member

@erikgb erikgb commented Feb 14, 2026

The previous download location, https://go.kubebuilder.io/test-tools, is no longer available. This can be seen in the currently failing PR: #102.

I didn't want to spend a lot of time fixing this, so I just ripped some code from the kubebuilder testdata setup in https://github.com/kubernetes-sigs/kubebuilder/blob/59b97dd38d0f6c3f2b5e05f3d4767bd0be6b9fb3/testdata/project-v4/Makefile. The code looks awful, but it appears to work. 😅

@cert-manager-prow cert-manager-prow bot added dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 14, 2026
@erikgb erikgb force-pushed the fix-envtest-install branch from 8688344 to 8aba2b2 Compare February 14, 2026 16:07
@cert-manager-prow cert-manager-prow bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. and removed dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. labels Feb 14, 2026
@erikgb
Copy link
Member Author

erikgb commented Feb 14, 2026

/cc @SgtCoDFish

@erikgb erikgb force-pushed the fix-envtest-install branch 4 times, most recently from 8b6f56d to b8f8a45 Compare February 14, 2026 17:12
Signed-off-by: Erik Godding Boye <egboye@gmail.com>
@erikgb erikgb force-pushed the fix-envtest-install branch from b8f8a45 to ce87fbf Compare February 14, 2026 17:21
Copy link
Member

@SgtCoDFish SgtCoDFish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Looks good from a quick glance!

@cert-manager-prow cert-manager-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 17, 2026
@cert-manager-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SgtCoDFish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 17, 2026
@cert-manager-prow cert-manager-prow bot merged commit 2210996 into cert-manager:master Feb 17, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants