Replace node-markdown-spellcheck with cspell for spell checking#1986
Open
Abmarne wants to merge 6 commits intocert-manager:masterfrom
Open
Replace node-markdown-spellcheck with cspell for spell checking#1986Abmarne wants to merge 6 commits intocert-manager:masterfrom
Abmarne wants to merge 6 commits intocert-manager:masterfrom
Conversation
cert-manager-prow
bot
added
the
dco-signoff: no
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
cert-manager-prow
bot
added
the
size/S
Abmarne
changed the title
Abmarne
changed the title
Abmarne
changed the title
Signed-off-by: Abhiraj Marne <abhirajmarne11@gmail.com>
cert-manager-prow
bot
added
dco-signoff: yes
Signed-off-by: Abhiraj Marne <abhirajmarne11@gmail.com>
cert-manager-prow
bot
added
size/XXL
✅ Deploy Preview for cert-manager ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Signed-off-by: Abhiraj Marne <abhirajmarne11@gmail.com>
Member
|
@Abmarne, thanks for picking this up! ❤️ You can probably add ignore configuration of all "historical" documentation. |
Signed-off-by: Abhiraj Marne <abhirajmarne11@gmail.com>
Signed-off-by: Abhiraj Marne <abhirajmarne11@gmail.com>
Signed-off-by: Abhiraj Marne <abhirajmarne11@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've replaced the unmaintained node-markdown-spellcheck with cspell. Here's a summary of the changes:
Fix: #1985
Changes made:
package.json:
Replaced markdown-spellcheck devDependency with cspell (v8.19.3)
Updated check:spelling script to use cspell CLI
cspell.json (new file):
Configured cspell to use the existing .spelling file as a custom dictionary
Added ignore paths for node_modules, api-docs, etc.
README.md:
Updated reference from mdspell to cspell
Why cspell?
Actively maintained (latest version published 17 hours ago)
Well-established with 124+ stars on GitHub
Supports custom dictionaries (reuses existing .spelling file)
Fast and feature-rich spell checker for code