Closed
Conversation
usual2970
reviewed
Sep 27, 2024
| signer, err := sshPkg.ParsePrivateKey([]byte(access.Key)) | ||
| var signer sshPkg.Signer | ||
| var err error | ||
| if access.Password != "" { |
Member
There was a problem hiding this comment.
密码这么用，用户会产生疑惑：这个密码到底是用户的密码，还是私钥的密码？
- 可以在前端加个选项
- 或者在本地解析完再上传
Author
There was a problem hiding this comment.
那Username到底是不是私钥对应的用户？
加个选项感觉有点多余，看项目里面本身是私钥优先 所以密码对应私钥也说得过去吧
要不就加一个Authentication type: Password、Keypair 由用户选择 类似idea上的功能，
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.