enhance: resolve error on tencent cdn dupe deployment#273
Merged
usual2970 merged 2 commits intocertimate-go:mainfrom Oct 29, 2024
Merged
enhance: resolve error on tencent cdn dupe deployment#273usual2970 merged 2 commits intocertimate-go:mainfrom
usual2970 merged 2 commits intocertimate-go:mainfrom
Conversation
Contributor
LeoChen98
commented
Oct 27, 2024
LeoChen98
commented
- 优化：腾讯云cdn重复部署报错的问题
优化：腾讯云cdn重复部署报错的问题
fudiwei
reviewed
Oct 28, 2024
fudiwei
reviewed
Oct 30, 2024
Comment on lines
+153
to
+155
| if(slices.Contains(deployedDomains, domainStr)){ | ||
| domains = append(domains, domainStr) | ||
| } |
Member
There was a problem hiding this comment.
@LeoChen98 我正在重构 Deployer 的相关逻辑，这个地方没太看懂。从代码上看这里是要取“包含在已部署过的域名里的域名”（即交集）？但从 PR 信息上看似乎是要跳过已部署过的域名才对（即差集）？
Member
There was a problem hiding this comment.
草，漏了个
!逻辑反了(x
😂 没事儿，我在新的 PR 里一并 fix 了吧
Contributor
Author
There was a problem hiding this comment.
我改一下吧
辛苦了，我本来想手机改，结果死活登录不上，同步不了fork，有被github app气到
Contributor
Author
There was a problem hiding this comment.
我改一下吧
另外，这个问题可能导致腾讯云cdn部署功能不可用，可能需要推紧急发版。私密马赛
Closed
usual2970
added a commit
that referenced
this pull request
Nov 5, 2024
enhance: resolve error on tencent cdn dupe deployment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.