feat: enhance apply logic#411
Merged
usual2970 merged 6 commits intocertimate-go:nextfrom Jan 12, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
该 PR 包含以下内容变更:
ApplyDNSProvider。详见备注 ①【备注】
①
现有的申请证书时的提供商类型判定直接依赖于
AccessProvider。但实际上部分云服务商旗下会有多个域名管理的云服务(如 AWS 下既有 Route53 又有 Lightsail;火山引擎下既有 DNS 又有 PrivateZone;等等),它们实际共享相同的Access授权信息。虽然目前 certimate 仅实现了这些云服务商的其中一个云服务,并将其视为默认的 DNSProvider。但出于日后扩展考虑,有必要将 Provider 进一步细化,细化的结果为:
AccessProvider:(已有)授权提供商。DeployProvider:(已有)部署证书时的主机提供商,其授权信息依赖于AccessProvider。ApplyDNSProvider: (新增)申请证书时的 DNS 提供商,其授权信息依赖于AccessProvider。②
现有的授权管理中某些提供商的授权参数,实际是其申请证书阶段所需的业务参数(如 AWS 的
region、hostedZoneId;华为云的region;等等),这些参数与授权本身无关,放在授权管理页面中容易产生误解或困惑。因此,有必要将它们从授权管理中独立出来,放到工作流的申请阶段单独填写。