Skip to content

feat: add cmcc dns#436

Closed
hujingnb wants to merge 1 commit intocertimate-go:nextfrom
hujingnb:feat/cmcc
Closed

feat: add cmcc dns#436
hujingnb wants to merge 1 commit intocertimate-go:nextfrom
hujingnb:feat/cmcc

Conversation

@hujingnb
Copy link
Copy Markdown
Contributor

@hujingnb hujingnb commented Jan 30, 2025

@hujingnb hujingnb changed the title feat: add cmcc dns WIP:feat: add cmcc dns Jan 30, 2025
@hujingnb hujingnb force-pushed the feat/cmcc branch 2 times, most recently from eb1eb31 to b30a1b8 Compare January 30, 2025 11:45
@hujingnb hujingnb changed the title WIP:feat: add cmcc dns feat: add cmcc dns Jan 30, 2025
fudiwei
fudiwei reviewed Jan 30, 2025
View reviewed changes
Comment thread ui/src/components/access/AccessForm.tsx Outdated
fudiwei
fudiwei reviewed Jan 30, 2025
View reviewed changes
Comment thread ui/src/components/access/AccessForm.tsx Outdated
fudiwei
fudiwei reviewed Jan 30, 2025
View reviewed changes
Comment thread ui/src/domain/access.ts Outdated
fudiwei
fudiwei reviewed Jan 30, 2025
View reviewed changes
Comment thread ui/src/domain/provider.ts Outdated
fudiwei
fudiwei reviewed Jan 30, 2025
View reviewed changes
Comment thread internal/pkg/vendors/cmcc-sdk/README.md
fudiwei
fudiwei reviewed Jan 30, 2025
View reviewed changes
Comment thread internal/domain/access.go Outdated
fudiwei
fudiwei reviewed Jan 30, 2025
View reviewed changes
Comment thread internal/pkg/core/applicant/acme-dns-01/lego-providers/cmcc/lego.go Outdated
@fudiwei fudiwei added enhancement New feature or request help wanted Extra attention is needed invalid This doesn't seem right labels Jan 30, 2025
fudiwei
fudiwei reviewed Jan 30, 2025
View reviewed changes
Comment thread ui/src/i18n/locales/en/nls.access.json Outdated
fudiwei
fudiwei reviewed Jan 30, 2025
View reviewed changes
Comment thread ui/src/i18n/locales/zh/nls.access.json Outdated
fudiwei
fudiwei reviewed Jan 30, 2025
View reviewed changes
Comment thread ui/src/i18n/locales/en/nls.common.json Outdated
fudiwei
fudiwei reviewed Jan 30, 2025
View reviewed changes
Comment thread ui/src/i18n/locales/zh/nls.common.json Outdated
@fudiwei
Copy link
Copy Markdown
Member

fudiwei commented Jan 30, 2025

@hujingnb 感谢贡献代码，这个 PR 需要做出一些调整，麻烦根据批注修改一下。

新年快乐~ 😀

@hujingnb hujingnb force-pushed the feat/cmcc branch 2 times, most recently from 8257276 to e1decb2 Compare January 30, 2025 16:01
@hujingnb
Copy link
Copy Markdown
Contributor Author

hujingnb commented Jan 30, 2025 •
edited
Loading

@hujingnb 感谢贡献代码，这个 PR 需要做出一些调整，麻烦根据批注修改一下。

新年快乐~ 😀

已处理. 感谢审核, 新年快乐

fudiwei
fudiwei reviewed Jan 31, 2025
View reviewed changes
Comment thread internal/pkg/core/applicant/acme-dns-01/lego-providers/cmcc/cmcc.go
@hujingnb hujingnb force-pushed the feat/cmcc branch 3 times, most recently from 6505e01 to e40d521 Compare January 31, 2025 11:26
@hujingnb hujingnb requested a review from fudiwei January 31, 2025 11:27
@hujingnb
Copy link
Copy Markdown
Contributor Author

hujingnb commented Feb 18, 2025

以上问题均已修复, 辛苦复查

@hujingnb hujingnb force-pushed the feat/cmcc branch 2 times, most recently from 97490df to 1d80b0d Compare February 20, 2025 03:46
@hujingnb hujingnb force-pushed the feat/cmcc branch 2 times, most recently from f2b5223 to d722a59 Compare February 20, 2025 03:50
@fudiwei fudiwei mentioned this pull request Feb 20, 2025
Merged
@fudiwei
Copy link
Copy Markdown
Member

fudiwei commented Feb 20, 2025

@hujingnb 该 PR 内容与基线相差过大，会有较多冲突。已将相关变更移动至 #456 中，后续请关注此 PR。

@fudiwei fudiwei closed this Feb 20, 2025
@fudiwei fudiwei removed the help wanted Extra attention is needed label Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fudiwei fudiwei Awaiting requested review from fudiwei

Assignees

No one assigned

Labels

enhancement New feature or request invalid This doesn't seem right

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

希望增加移动云

2 participants

@hujingnb @fudiwei