Skip to content

feat: open viewer from dirty editor#449

Merged
lcottercertinia merged 3 commits into
certinia:mainfrom
lukecotter:feat-open-viewer-from-dirty-editor
Nov 20, 2023
Merged

feat: open viewer from dirty editor#449
lcottercertinia merged 3 commits into
certinia:mainfrom
lukecotter:feat-open-viewer-from-dirty-editor

Conversation

@lukecotter

Copy link
Copy Markdown
Collaborator

Description

feat: open viewer with editor content if file does not exist

This is mainly to support drag and drop file in code builder.
It also helps when a file is deleted on local disk or a log is
copy and pasted into an editor window without saving.

Type of change (check all applicable)

  • 🐛 Bug fix
  • ✨ New feature
  • ♻️ Refactor
  • ⚡ Performance Improvement
  • 📝 Documentation
  • 🔧 Chore
  • 💥 Breaking change

[optional] Any images / gifs / video

Related Tickets & Documents

Related Issue #
fixes #
resolves #213
closes #

Added tests?

  • 👍 yes
  • 🙅 no, not needed
  • 🙋 no, I need help

Added to documentation?

  • 🔖 README.md
  • 🔖 CHANGELOG.md
  • 📖 help site
  • 🙅 not needed

[optional] Are there any post-deployment tasks we need to perform?

This is mainly to support drag and drop file in code builder.
It also helps when a file is deleted on local disk or a log is
copy and pasted into an editor window without saving.
@lcottercertinia lcottercertinia merged commit 35a10ba into certinia:main Nov 20, 2023
@lukecotter lukecotter deleted the feat-open-viewer-from-dirty-editor branch November 20, 2023 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: viewer should work in code builder if file is dragged into browser

2 participants