bug(perf): regression in call tree render performance#580
Merged
lcottercertinia merged 4 commits intocertinia:mainfrom Mar 26, 2025
Merged
bug(perf): regression in call tree render performance#580lcottercertinia merged 4 commits intocertinia:mainfrom
lcottercertinia merged 4 commits intocertinia:mainfrom
Conversation
Avoid cleartimeout firing thousands of times, once for each expanded row. Will only execute when there is a row to focus on.
…/ shown The calculation to find the middle row was using the table height inlcuding columns headers + footer. It should have been using only the scrollable div containing rows.
lcottercertinia
approved these changes
Mar 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
requestAnimationFrame(RAF) regardless of whether there could possibly be any text to highlight (no search had been done), this is now skipped unless needed.MiddleRowFocuswas always addingsetTimeoutto the task queue event if there was no row to focus on, this is now skipped unless needed.TODO
Type of change (check all applicable)
[optional] Any images / gifs / video
Related Tickets & Documents
Related Issue #
fixes #581
resolves #
closes #
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?