build(codicons): inline font via postcss-url, drop vendored css#780
Merged
lcottercertinia merged 1 commit intoMay 22, 2026
Merged
Conversation
…red css - import `@vscode/codicons/dist/codicon.css` directly in components and drop the 2000-line vendored copy in log-viewer/src/styles/codicon.css - add postcss-url plugin (url: 'inline', base64) to rolldown/rollup configs so the codicon.ttf @font-face url is bundled into the css, removing the separate copy step for codicon.ttf - simplify LogView.ts webview html substitution to bundle.js only; ${extensionRoot} is no longer referenced now that the font is inlined - reformat log-viewer/index.html (prettier) and drop the now-dead @font-face block
lcottercertinia
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 PR Overview
Replace the 2000-line vendored
codicon.csscopy with a direct import of@vscode/codicons/dist/codicon.css, and usepostcss-urlto inline thecodicon.ttffont as a base64 data URI inside the bundled CSS. This removes a manual copy step and keeps the codicon assets in sync with the upstream package.🛠️ Changes made
@vscode/codicons/dist/codicon.cssdirectly in components and delete the vendoredlog-viewer/src/styles/codicon.csspostcss-urlplugin (url: 'inline', base64) torolldown.config.tsandrollup.config.mjsso the@font-faceurl forcodicon.ttfis inlined into the bundled CSSLogView.tswebview HTML substitution tobundle.jsonly;${extensionRoot}is no longer needed now that the font is inlinedlog-viewer/index.html(prettier) and drop the now-dead@font-faceblock🧩 Type of change (check all applicable)
📷 Screenshots / gifs / video [optional]
No visual change — codicons render identically; this is a build/packaging change.
🔗 Related Issues
n/a
✅ Tests added?
📚 Docs updated?
Anything else we need to know? [optional]
Manual smoke: open a log in the webview and confirm codicons (toolbar, nav, find widget, tabs) render with no missing-glyph boxes and no separate
codicon.ttfrequest in the network panel.