Added MDNS and driver support for multicast #3093
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertc2000
force-pushed
the
mdns-multicast
branch
3 times, most recently
from
a0fad63 to
138080d
Compare
scaprile
approved these changes
Apr 9, 2025
cpq
reviewed
Apr 11, 2025
| } | ||
|
|
||
| #if MG_ENABLE_MDNS | ||
| static const uint8_t mdns_answer[] = { |
Member
There was a problem hiding this comment.
I'd declare this in the handler as a stack variable.
cpq
approved these changes
Apr 11, 2025
src/config.h
Outdated
| #endif | ||
|
|
||
| #if MG_ENABLE_TCPIP | ||
| #if MG_ENABLE_MDNS |
Member
There was a problem hiding this comment.
Why those constants? I suggest to have MG_ENABLE_MDNS and MG_ENABLE_MCAST always enabled
scaprile
force-pushed
the
mdns-multicast
branch
4 times, most recently
from
bf80550 to
1f4e115
Compare
Member
|
Merging this ? |
scaprile
force-pushed
the
mdns-multicast
branch
4 times, most recently
from
b1e26b3 to
439c5ba
Compare
scaprile
force-pushed
the
mdns-multicast
branch
from
439c5ba to
1d2a768
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.