chore(git): Do not ignore lockfile for reproducible build#3
Merged
cestef merged 1 commit intocestef:mainfrom Dec 30, 2024
pwnwriter:main
Merged
chore(git): Do not ignore lockfile for reproducible build#3cestef merged 1 commit intocestef:mainfrom pwnwriter:main
cestef merged 1 commit intocestef:mainfrom
pwnwriter:main
Conversation
Cargo lockfile is necessary for build/packging for nix
Owner
|
Thanks alot ! I remember not wanting to include the lockfile for some reason but I forgot why, probably wasn't that important 🤷 |
Owner
|
commitizen-tools/commitizen#1201 ah yes this was it, commitizen doesn't include the updated |
Contributor
Author
|
Some impressive work you did here on rwalk. I really liked the tool. Could you publish a minor version with lock file to crates.io? I've option to provide lock file myself but that doesn't make a good option than just using the upstream one. |
Owner
|
I tried to bump it yesterday but it seems like the ci didn't fire, I'll take a look at this asap 👍 |
Owner
|
https://crates.io/crates/rwalk/0.9.0 pushed 0.9.0 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cargo lockfile is necessary for build/packging for nix
I was packaging
rwalkfor nix and noticed a couple of things needs to be fixed first.