Partial updates#24
Merged
Merged
Conversation
* Added `config.EnvSSHDefaultUsername`, with the default set to
`os.Getenv("USER")`
* Updated `config.Settings` to add `EnvSSHDefaultUsername`
* Fixed issue in `ssh.setIdentity` where the default key path
was static
* Fixed outdated overrides in `Makefile` following refactor
* Added `cmd.updateConnection` to handle partial updates, which will currently fail when an existing connection is not found and directs the user to use `write` * Updated `cmd.writeConnection` to fail when an existing connection is found an directs the user to use `update` * Added `cmd.updateCmd` and added support for `--comment` with it
* Updated the message in `cmd` for `Debugf` * Fixed typo in `--comment` help for `updateCmd`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the
updatecommand to support partial updates.When an existing connection is detected then the update will take place, however if one is not found then the user will be directed to use the
writecommand instead, and vice versa. Update of the comment is supported with this.cmd.updateConnectionto handle partial updates, whichwill currently fail when an existing connection is not found and
directs the user to use
writecmd.writeConnectionto fail when an existing connectionis found an directs the user to use
updatecmd.updateCmdand added support for--commentwith itAddition changes:
config.EnvSSHDefaultUsername, with the default set toos.Getenv("USER")config.Settingsto addEnvSSHDefaultUsernamessh.setIdentitywhere the default key pathwas static
Makefilefollowing refactorAddresses #5