Conversation
Due to the locks using the same code as the config requests, warning messages previously appeared when there is no lock, which is the scenario that you want to have. The message is no longer emitted when making a lock request. * Updated `cmd.getRawConnection` to check if the key is prefixed with the `LockPrefix`, returning 'no lock found' instead of 'no match found' when true * Updated `cmd.TestGetRawConnection` to ensure that a lock request returns 'no lock found' Fixes #48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to the locks using the same code as the config requests,
warning messages previously appeared when there is no lock, which
is the scenario that you want to have. The message is no longer
emitted when making a lock request.
cmd.getRawConnectionto check if the key is prefixedwith the
LockPrefix, returning 'no lock found' instead of'no match found' when true
cmd.TestGetRawConnectionto ensure that a lock requestreturns 'no lock found'
Fixes #48