Remove warning during write#59
Merged
Merged
Conversation
When writing a new connection, an unnecessary warning iappears: ```shell level=warning msg="Unable to find connection for: xxx" ``` * Added `currentCommand` var to `cmd` and set it during the connection commands for ease of detection. * Updated `cmd.getRawConnection` to bypass warnings when `currentCommand == "write"` * Updated `cmd.TestGetRawConnection` to ensure that the correct error is raised for the connection commands Fixes #58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When writing a new connection, an unnecessary warning iappears:
level=warning msg="Unable to find connection for: xxx"currentCommandvar tocmdand set it during theconnection commands for ease of detection.
cmd.getRawConnectionto bypass warnings whencurrentCommand == "write"cmd.TestGetRawConnectionto ensure that thecorrect error is raised for the connection commands
Fixes #58