Conversation
Previously, connections were only cached by specifically requesting them via commands such as `connect`, `write`, etc. Purging was possible via the `purge` command, but only the entire cache could be purged, which isn't always desirable. A new command, `cache`, has been created with subcommands for supported operations on the cache, which currently is limited to populating and purging. * Added `cmd.cacheCmd`, renamed `cmd.purgeCmd` to `cmd.purgeCachCmd` and moved it to be a subcommand * Added flags to purging so that the operation can be forced (`-f`) so that confirmation can be bypassed, as well as now being able to specify a specific connection (`-c`) to limit purging * Added `cmd.populateCacheCmd` that will iterate the full list of available connections and wriute each to the cache. This allows for a user to populate the entire set of connections at any given point and thus be able to avoid issues where Vault might be unavailable and an uncached connection is requested * Updated tests to include populatting and purging connections
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, connections were only cached by specifically requesting
them via commands such as
connect,write, etc. Purging waspossible via the
purgecommand, but only the entire cache couldbe purged, which isn't always desirable.
A new command,
cache, has been created with subcommands forsupported operations on the cache, which currently is limited to
populating and purging.
cmd.cacheCmd, renamedcmd.purgeCmdtocmd.purgeCachCmdand moved it to be a subcommand-f)so that confirmation can be bypassed, as well as now being able to
specify a specific connection (
-c) to limit purgingcmd.populateCacheCmdthat will iterate the full list ofavailable connections and wriute each to the cache. This allows for
a user to populate the entire set of connections at any given point
and thus be able to avoid issues where Vault might be unavailable
and an uncached connection is requested
Resolves #71