Conversation
In cases where the remote server supports environment variables being passed across, adding support for storing SendEnv XXX would be useful. * Added `SendEnv` to `ssh.Connection` to store environment var names to pass across * Added `ssh.setSendEnv` and updated `ssh.BuildConnection` to call `setSendEnv` * Updated `ssh.Connect` to search for `SendEnv` and apply each var to `cmd.Env` * Updated unit tests
* Added `ssh.SkipOnEmpty` to map options that should be omitted from both execution and display (`connect`, `print` and `show`) * Refactored `ssh.BuildConnection` to bypass any `ssh.SkipOnEmpty` matches, removing redundant code * Updated unit tests
Oneiroi
approved these changes
Nov 19, 2021
Owner
Author
If you mean |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In cases where the remote server supports environment variables
being passed across, adding support for storing SendEnv XXX
would be useful.
SendEnvtossh.Connectionto store environment varnames to pass across
ssh.setSendEnvand updatedssh.BuildConnectiontocall
setSendEnvssh.Connectto search forSendEnvand apply eachvar to
cmd.Envssh.SkipOnEmptyto map options that should be omittedfrom both execution and display (
connect,printandshow)ssh.BuildConnectionto bypass anyssh.SkipOnEmptymatches, removing redundant code
Resolves #54