Conversation
The currently supported architectures are: * `linux/amd64` * `darwin/amd64` Support for the M1 is required. Resolves #84
cezmunsta
added
enhancement
Oneiroi
reviewed
Apr 28, 2022
Collaborator
Oneiroi
left a comment
Oneiroi
left a comment
There was a problem hiding this comment.
Makefile changes appear sane, however as per slack some of the tests are failing:
make test
ok github.com/cezmunsta/ssh_ms/ssh 0.408s
# github.com/shirou/gopsutil/disk
iostat_darwin.c:28:2: warning: 'IOMasterPort' is deprecated: first deprecated in macOS 12.0 [-Wdeprecated-declarations]
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/IOKit.framework/Headers/IOKitLib.h:132:1: note: 'IOMasterPort' has been explicitly marked deprecated here
# github.com/shirou/gopsutil/host
smc_darwin.c:75:41: warning: 'kIOMasterPortDefault' is deprecated: first deprecated in macOS 12.0 [-Wdeprecated-declarations]
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/IOKit.framework/Headers/IOKitLib.h:123:19: note: 'kIOMasterPortDefault' has been explicitly marked deprecated here
1.7.0
time="2022-04-28T12:23:44+01:00" level=fatal msg="Failed to lookup https://github.com/cezmunsta/ssh_ms/releases/latest"
FAIL github.com/cezmunsta/ssh_ms/cmd 11.068s
ok github.com/cezmunsta/ssh_ms/vault 4.246s
ok github.com/cezmunsta/ssh_ms/log 0.193s
ok github.com/cezmunsta/ssh_ms/config 0.291s
FAIL
make: *** [test] Error 1
Collaborator
|
Tests are passing 👍 |
Owner
Author
Cheers for checking! 🍻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The currently supported architectures are:
linux/amd64darwin/amd64Support for the M1 is required.
Resolves #84