Fix AWS AMI lookup matching wrong Ubuntu version#178
Merged
larsewi merged 1 commit intocfengine:masterfrom Apr 28, 2026
Merged
Conversation
The generic ubuntu name_pattern formatted to `ubuntu-*-20*`, which also matched newer releases via their 20XX build-date suffix (e.g. `ubuntu-jammy-22.04-...-20231201`). The newest by creation date won, so `--platform ubuntu-20` spawned Ubuntu 22. Anchor on the version dot so only matching releases are returned. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
craigcomstock
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The generic
ubuntuAMIname_patternformatted toubuntu-*-20*, which also matched newer releases via their20XXbuild-date suffix (e.g.ubuntu-jammy-22.04-...-20231201)._get_ami()picks the newest by creation date, so--platform ubuntu-20was spawning Ubuntu 22.Anchor the version on the dot (
{version}.*) soubuntu-20only matchesubuntu-*-20.04-*, etc. Same fix applied to theubuntu-24entry for consistency.🤖 Generated with Claude Code