CFE-4679: Replaced secrets-module with SystemRandom & removed caching for legacy python versions in gh-action#185
Merged
Conversation
Ticket: CFE-4679 Signed-off-by: Simon Halvorsen <simon.halvorsen@northern.tech>
575f3d4 to
f339697
Compare
Ticket: CFE-4679 Signed-off-by: Simon Halvorsen <simon.halvorsen@northern.tech>
Contributor
Author
larsewi
approved these changes
Jun 5, 2026
Contributor
|
Thanks 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Python secrets-module does not exist for 3.5, replaced with the SystemRandom (what secrets use behind the scenes)
Removed caching as this sets wrong python version for the legacy-setup