CFE-4538: Add more unit test coverage #234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 23, 2025
olehermanse
reviewed
Jun 23, 2025
olehermanse
requested changes
Jun 23, 2025
Member
olehermanse
left a comment
olehermanse
left a comment
There was a problem hiding this comment.
Nice, now it's easy to see that this PR is only changing tests. Please squash the 2 commits into 1.
Signed-off-by: jakub-nt <175944085+jakub-nt@users.noreply.github.com>
jakub-nt
changed the title
olehermanse
reviewed
Jun 23, 2025
olehermanse
reviewed
Jun 23, 2025
olehermanse
approved these changes
Jun 23, 2025
Member
olehermanse
left a comment
olehermanse
left a comment
There was a problem hiding this comment.
Looks good, feel free to add some of the missing asserts I requested over in a follow-up PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.