Refactoring, validation, and other improvements to replace and replace_version #245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ole Herman Schumacher Elgesem <ole.elgesem@northern.tech>
Signed-off-by: Ole Herman Schumacher Elgesem <ole.elgesem@northern.tech>
Signed-off-by: Ole Herman Schumacher Elgesem <ole.elgesem@northern.tech>
Signed-off-by: Ole Herman Schumacher Elgesem <ole.elgesem@northern.tech>
olehermanse
force-pushed
the
replace_more
branch
2 times, most recently
from
7403806 to
c8ed5f4
Compare
Signed-off-by: Ole Herman Schumacher Elgesem <ole.elgesem@northern.tech>
Signed-off-by: Ole Herman Schumacher Elgesem <ole.elgesem@northern.tech>
There are a few reasons for doing this: - Makes it possible to catch this exception. - Makes it possible for tools to know what return types a function return. Before this, things like PyRight aren't able to deduce that the function "stops" at user_error(). - Same argument could be made for making it easier for humans to read. - Make it possible to handle this error in one centralized place along with the other error types, in main(). Signed-off-by: Ole Herman Schumacher Elgesem <ole.elgesem@northern.tech>
This is a more honest name, given that we've been using this everywhere, even for things which are not the user's fault. Signed-off-by: Ole Herman Schumacher Elgesem <ole.elgesem@northern.tech>
Signed-off-by: Ole Herman Schumacher Elgesem <ole.elgesem@northern.tech>
Signed-off-by: Ole Herman Schumacher Elgesem <ole.elgesem@northern.tech>
olehermanse
force-pushed
the
replace_more
branch
2 times, most recently
from
a9ef5e8 to
1aad5c0
Compare
Signed-off-by: Ole Herman Schumacher Elgesem <ole.elgesem@northern.tech>
Signed-off-by: Ole Herman Schumacher Elgesem <ole.elgesem@northern.tech>
larsewi
approved these changes
Jul 4, 2025
Contributor
larsewi
left a comment
larsewi
left a comment
There was a problem hiding this comment.
Looks good. Maybe you can squash some of the commits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.