ENT-13808: Improve release history generation and download handling#51
Merged
olehermanse merged 2 commits intocfengine:mainfrom Apr 17, 2026
Merged
Conversation
|
Thanks for submitting a PR! Maybe @larsewi can review this? |
olehermanse
requested changes
Apr 10, 2026
Comment on lines
99
to
100
| def process_release_type(folder, download_func): | ||
| # Function for processing either community or enterprise releases |
Member
There was a problem hiding this comment.
This function was here already, but looking at it, I wonder if it unnecessarily complex.
Why is it necessary to pass in a download function, instead of just a download URL?
| # Downloading releases.json: | ||
| try: | ||
| releases_data = get_json(ENTERPRISE_RELEASES_URL) | ||
| return requests.get(ENTERPRISE_RELEASES_URL) |
Member
There was a problem hiding this comment.
Here you change the return type from json / dict to a requests response object. However, where you use this, you only use response.content, right? Maybe it's cleaner to just return .content? When I write functions that essentially wrap requests in various ways, I usually like to not "leak" the fact that it is requests.
Comment on lines
+186
to
+203
| def save_to_file(path, content): | ||
| try: | ||
| with open(path, "wb") as f: | ||
| f.write(content) | ||
| print(f"Saved {path}") | ||
|
|
||
| except OSError: | ||
| raise CFBSExitError(f"Failed to write file {path}.") | ||
|
|
||
|
|
||
| def load_json_from_file(path): | ||
| # Open saved file and return as dict | ||
| try: | ||
| with open(path, "r", encoding="utf-8") as f: | ||
| return json.load(f) | ||
|
|
||
| except OSError: | ||
| raise CFBSExitError(f"Failed to read file {path}.") |
Member
There was a problem hiding this comment.
I was thinking we could make a function which does "everything" you need, without saving the data to file and then reading it from file again;
def json_get_save_return(url: str, path: str) -> dict:
r = requests.get(url)
content = r.content
with open(path, "wb") as f:
f.write(content)
# TODO: Add some error handling
data = json.loads(content)
return data
sarakthon
force-pushed
the
generate-community-checksums
branch
from
2c27558 to
1c4ce4c
Compare
…to top of generate_release_information_impl
sarakthon
force-pushed
the
generate-community-checksums
branch
3 times, most recently
from
47efe87 to
6c70444
Compare
sarakthon
force-pushed
the
generate-community-checksums
branch
from
6c70444 to
c3df853
Compare
olehermanse
reviewed
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.