Skip to content

Fixed length checking in StatFile #5961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 25, 2025
Merged

Fixed length checking in StatFile #5961

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions cf-serverd/server_common.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -732,6 +732,7 @@ int StatFile(ServerConnectionState *conn, char *sendbuffer, char *ofilename)
/* the simplest way to transfer the data is to convert them into */
/* plain text and interpret them on the other side. */
{
assert(conn != NULL);
Stat cfst;
struct stat statbuf, statlinkbuf;
char linkbuf[CF_BUFSIZE], filename[CF_BUFSIZE - 128];
Expand Down Expand Up @@ -874,10 +875,17 @@ int StatFile(ServerConnectionState *conn, char *sendbuffer, char *ofilename)

memset(sendbuffer, 0, CF_MSGSIZE);

// +3 because we need to prepend 'OK:' to the path
if (strlen(linkbuf)+3 > CF_MSGSIZE) {
NDEBUG_UNUSED int ret = snprintf(sendbuffer, CF_MSGSIZE, "BAD: Symlink resolves to a path too long (%ld) to send over the protocol.", strlen(linkbuf)+3);
assert(ret > 0 && ret < CF_MSGSIZE);
SendTransaction(conn->conn_info, sendbuffer, 0, CF_DONE);
return -1;
}
if (cfst.cf_readlink != NULL)
{
strcpy(sendbuffer, "OK:");
strcat(sendbuffer, cfst.cf_readlink);
NDEBUG_UNUSED int ret = snprintf(sendbuffer, CF_MSGSIZE, "OK:%s", linkbuf);
assert(ret > 0 && ret < CF_MSGSIZE);
}
else
{
Expand Down
Loading