Skip to content

Added mpf_masterfiles_stage_build_always flag file to enable legacy behavior of masterfiles-stage to always run cfbs build (3.24) #6112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
craigcomstock merged 1 commit into from
May 5, 2026
Merged

Added mpf_masterfiles_stage_build_always flag file to enable legacy behavior of masterfiles-stage to always run cfbs build (3.24) #6112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions contrib/masterfiles-stage/README.org
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,16 @@ are pre-installed when using CFEngine Enterprise.

Next, configure the default parameter set (=DEFAULT_PARAMS_FILE=).

*** Legacy behavior

Before CFEngine 3.24.0 release the cfbs variant of this script would run cfbs build every update policy run.

This could be used to run scripts to dynamically create files in the policy set but also broke one important feature of cfbs build which is to make deterministic builds that result in the same outputs given the same inputs.

The new default behavior as of 3.24.0 is to not run cfbs build if the repository has not changed.

As of release 3.24.4, 3.27.1 and 3.28.0 you can restore this legacy behavior by touching the file /var/cfengine/state/mpf_masterfiles_stage_build_always.flag.

*** Troubleshooting

You may experience issues trying to use the old versions of various dependencies. Try these solutions to common issues.
Expand Down
4 changes: 3 additions & 1 deletion contrib/masterfiles-stage/common.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,9 @@ git_cfbs_deploy_refspec() {
# We don't mkdir $1 directly, just its parent dir if that doesn't exist.

if git_check_is_in_sync "${local_mirrored_repo}" "$1" "$2"; then
return 0
if [ ! -f /var/cfengine/state/mpf_masterfiles_stage_build_always.flag ]; then
return 0
fi
fi

########################## 1. CREATE EMPTY TEMP DIR
Expand Down
Loading