Skip to content

2024 Craig User Test Edits #3226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 20, 2024
Merged

2024 Craig User Test Edits #3226

merged 3 commits into from
Feb 20, 2024

Conversation

@craigcomstock
Copy link
Contributor

@craigcomstock craigcomstock commented Feb 20, 2024

No description provided.

@craigcomstock
Copy link
Contributor Author

craigcomstock commented Feb 20, 2024

@cf-bottom docs build please

@cf-bottom
Copy link

cf-bottom commented Feb 20, 2024

Alright, I triggered a build:

Build Status

Jenkins: https://ci.cfengine.com/job/fast-build-and-deploy-docs-master/530/

Documentation: http://buildcache.cfengine.com/packages/build-documentation-pr/jenkins-fast-build-and-deploy-docs-master-530/output/_site/

@craigcomstock craigcomstock marked this pull request as draft February 20, 2024 22:19
@craigcomstock
Copy link
Contributor Author

craigcomstock commented Feb 20, 2024

recent pr, cfengine/masterfiles#2835, broke a link, fix it maybe Build Status

@craigcomstock craigcomstock marked this pull request as ready for review February 20, 2024 22:46
@craigcomstock
Copy link
Contributor Author

craigcomstock commented Feb 20, 2024

@cf-bottom jenkins docs build please

@craigcomstock
Copy link
Contributor Author

craigcomstock commented Feb 20, 2024

@nickanderson changes before I muddled with host page: http://buildcache.cfengine.com/packages/build-documentation-pr/jenkins-fast-build-and-deploy-docs-master-531/output/_site/web-ui.html

@cf-bottom
Copy link

cf-bottom commented Feb 20, 2024

Alright, I triggered a build:

Build Status

Jenkins: https://ci.cfengine.com/job/fast-build-and-deploy-docs-master/532/

Documentation: http://buildcache.cfengine.com/packages/build-documentation-pr/jenkins-fast-build-and-deploy-docs-master-532/output/_site/

nickanderson
nickanderson reviewed Feb 20, 2024
View reviewed changes
nickanderson
nickanderson approved these changes Feb 20, 2024
View reviewed changes
Copy link
Member

@nickanderson nickanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion, but approved.

@craigcomstock
Fixed small typos/issues on WebUI Hosts page
b13d760 
Co-authored-by: Nick Anderson <nick@cmdln.org>
@craigcomstock craigcomstock force-pushed the 2024-craig-user-test-edits branch from c1efedb to b13d760 Compare February 20, 2024 23:04
@craigcomstock craigcomstock merged commit a8e9090 into cfengine:master Feb 20, 2024
@craigcomstock craigcomstock deleted the 2024-craig-user-test-edits branch February 20, 2024 23:04
@olehermanse
Copy link
Member

olehermanse commented Feb 21, 2024

Cherry-pick: #3228

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickanderson nickanderson nickanderson approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@craigcomstock @cf-bottom @olehermanse @nickanderson