-
Notifications
You must be signed in to change notification settings - Fork 104
ENT-11371 MPF.md: Fixed many inconsistencies #2835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This file is shown in our docs and could use a cleanup. Went over this file trying to fix as many obvious / easy inconsistencies as I could: * Removed the use of h1, h5 and h6 headings. * Added JSON highlighting to code blocks. * Fixed invalid JSON (trailing commas, missing colons). * Fixed inconsistent indentation / formatting of code blocks. * Fixed capitalization of several headers to use sentence case. * Fixed capitalization of CFEngine, HTTP, HTTPS, etc. in a few places. * Added monospace font for binaries; cf-serverd, etc. * Fixed inconsistent markdown syntax (especially what should be bold and which symbols to use for bulleted lists). * Fixed small typos / grammer mistakes. * Renamed some headings to make them easier to understand. Ticket: ENT-11371 Signed-off-by: Ole Herman Schumacher Elgesem <ole@northern.tech>
Signed-off-by: Ole Herman Schumacher Elgesem <ole@northern.tech>
Signed-off-by: Ole Herman Schumacher Elgesem <ole@northern.tech>
larsewi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💩
craigcomstock
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good changes generally.
I would prefer we did one line per sentence style here but I guess some folks will read this in a console so 80-ish columns makes some sense.
thanks for all this busy work! appreciate it!
|
I opened a PR in docs to see the result of this: cfengine/documentation#3221 |
humm, maybe we add the necessary doc comments to enable line wrapping in the editors. I sort of prefer 80 column limit but do find myself using long lines with visual wrapping more and more. |
@craigcomstock I would also prefer it, but it didn't seem worth it, big file to edit. |
|
@nickanderson @craigcomstock IMO, it should be preferred, for the same reasons as in website repo: https://github.com/cfengine/website/blob/master/README.md#sentences-and-wrapping However, it's a big change and would require a lot of going around editing files manually, so I'm not about to venture down this path of doing it everywhere and making it required. In other words: it's recommended for now. |
nickanderson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple suggestions.
Co-authored-by: Nick Anderson <nick@cmdln.org>
Co-authored-by: Nick Anderson <nick@cmdln.org>
|
So fast docbuild won't pick up these changes until they are found in the nightly package. |
Too many conflicts, did this one manually. Based on: cfengine#2835 Signed-off-by: Ole Herman Schumacher Elgesem <ole@northern.tech>
Too many conflicts, did this one manually. Based on: cfengine#2835 Signed-off-by: Ole Herman Schumacher Elgesem <ole@northern.tech>
|
Backport: #2836 |
This file is shown in our docs and could use a cleanup.
Went over this file trying to fix as many obvious / easy inconsistencies as I could:
Ticket: ENT-11371