ENT-5562 Changed m_inventory dumping behavior to exclude when values is null (3.12.x feeders)#1751
Merged
nickanderson merged 1 commit intocfengine:masterfrom May 5, 2020
Conversation
craigcomstock
force-pushed
the
ENT-5562/master
branch
from
b2d8f93 to
2eb8928
Compare
craigcomstock
changed the title
Contributor
Author
|
@cf-bottom jenkins |
|
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/5095/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-5095/ |
vpodzime
reviewed
May 5, 2020
Contributor
vpodzime
left a comment
vpodzime
left a comment
There was a problem hiding this comment.
Looks good to me. Just please also add a comment about why we cannot use pg_dump for m_inventory.
Previously an empty values column in m_inventory such as when a host has not reported would cause corrupt SQL to be dumped. In this case we should simply not include that host in the output in a similar way that __inventory is built from v_inventory in latest schema. Changelog: Title Ticket: ENT-5562
craigcomstock
force-pushed
the
ENT-5562/master
branch
from
2eb8928 to
65cd6c4
Compare
Contributor
Author
Ok. Added a comment. Please approve and we can merge. |
nickanderson
approved these changes
May 5, 2020
nickanderson
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously an empty values column in m_inventory such as when a
host has not reported would cause corrupt SQL to be dumped.
In this case we should simply not include that host in the
output in a similar way that __inventory is built from v_inventory
in latest schema.
Changelog: Title
Ticket: ENT-5562