Moved systemd service management to own bundle#1803
Closed
nickanderson wants to merge 2 commits intocfengine:masterfrom
Closed
Moved systemd service management to own bundle#1803nickanderson wants to merge 2 commits intocfengine:masterfrom
nickanderson wants to merge 2 commits intocfengine:masterfrom
Conversation
This change moves the systemd service management promises to their own bundle. There should be no change in behavior as using standard_services when systemd is present will still result in the use of the same promises. This change makes it easier to maintain the policy as it is logically separate and allows explicit management of systemd services.
Member
Author
|
@craigcomstock, @vpodzime thoughts on this? |
Contributor
|
@nickanderson please check the travis failure and run jenkins on this |
Member
Author
|
@vpodzime Travis failures seem related to failed git clones, unrelated to this change. |
Member
Author
|
@cf-bottom jenkins, please |
|
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/5369/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-5369/ |
nickanderson
commented
Jul 15, 2020
| # | ||
| # * active - Service should be running, no promise about state on boot made. | ||
| # * inactive - Service should not be running, no promise about state on boot made. | ||
| # * restart - Service should be restarted, no promise about state on boot made. |
Member
Author
There was a problem hiding this comment.
oh, looks like I didnt finish the docs here. bad nick.
| # * inactive - Service should not be running, no promise about state on boot made. | ||
| # * restart - Service should be restarted, no promise about state on boot made. | ||
| # **Example:** | ||
| # |
Member
Author
There was a problem hiding this comment.
add example showing direct usage via methods as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change moves the systemd service management promises to their own bundle.
There should be no change in behavior as using standard_services when systemd is
present will still result in the use of the same promises. This change makes it
easier to maintain the policy as it is logically separate and allows explicit
management of systemd services.