CFE-3288 Adjusted package_module and paths for termux platform#1804
Merged
nickanderson merged 1 commit intocfengine:masterfrom Aug 3, 2020
Merged
CFE-3288 Adjusted package_module and paths for termux platform#1804nickanderson merged 1 commit intocfengine:masterfrom
nickanderson merged 1 commit intocfengine:masterfrom
Conversation
Contributor
Author
|
ah, right, package_module body interpreter attribute is not supported in 3.10.x, will adjust accordingly with macros right? |
craigcomstock
commented
Jul 16, 2020
craigcomstock
commented
Jul 16, 2020
craigcomstock
commented
Jul 22, 2020
craigcomstock
commented
Jul 22, 2020
craigcomstock
changed the title
Contributor
Author
|
WIP, need to double-check/test paths.(all the commands) to make sure things are "all good". |
nickanderson
requested changes
Jul 31, 2020
Member
nickanderson
left a comment
nickanderson
left a comment
There was a problem hiding this comment.
Seems pretty ok to me. just a couple small commetns.
Packages promises only possibly supported back to 3.15.1 due to need for interpreter attribute on package_module body and no earlier version available for termux. Paths added to support the interpreter path for packages. Also several convenience paths added both for termux and generic unix: - paths.tmp_path, paths.bin_path, paths.var_path, paths.etc_path Ticket: CFE-3288 Changelog: Title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Packages promises only possibly supported back to 3.15.1 due to
need for interpreter attribute on package_module body and no
earlier version available for termux.
Paths added to support the interpreter path for packages.
Also several convenience paths added both for termux and generic unix:
Ticket: CFE-3288
Changelog: Title