ENT-6035 Added duplicate host cleanup during FR import#1807
Merged
craigcomstock merged 1 commit intocfengine:masterfrom Aug 27, 2020
Merged
ENT-6035 Added duplicate host cleanup during FR import#1807craigcomstock merged 1 commit intocfengine:masterfrom
craigcomstock merged 1 commit intocfengine:masterfrom
Conversation
craigcomstock
force-pushed
the
ENT-6035/master
branch
from
ec4f1ac to
6b7da28
Compare
craigcomstock
force-pushed
the
ENT-6035/master
branch
from
6b7da28 to
17b1102
Compare
Contributor
Author
|
@nickanderson do you feel we should enable this de-dupe call by default? Or have it be an optional thing to enable by editing templates/federated_reporting/config.sh.mustache or even augments maybe? |
nickanderson
approved these changes
Aug 12, 2020
Member
nickanderson
left a comment
nickanderson
left a comment
There was a problem hiding this comment.
Seems simple enough, though I dunno the details of handle_duplicate_hostkeys_in_import. And looking forward to this being tunable off/on.
craigcomstock
force-pushed
the
ENT-6035/master
branch
from
69db78d to
a77dc24
Compare
nickanderson
approved these changes
Aug 12, 2020
vpodzime
reviewed
Aug 18, 2020
Contributor
vpodzime
left a comment
vpodzime
left a comment
There was a problem hiding this comment.
Looks good to me otherwise.
craigcomstock
force-pushed
the
ENT-6035/master
branch
from
a77dc24 to
b734e39
Compare
vpodzime
reviewed
Aug 26, 2020
Contributor
vpodzime
left a comment
vpodzime
left a comment
There was a problem hiding this comment.
Looks good to me otherwise.
vpodzime
reviewed
Aug 27, 2020
Contributor
vpodzime
left a comment
vpodzime
left a comment
There was a problem hiding this comment.
Please squash the review fixes.
This feature removes duplicate hostkey entries during federated reporting
import based on lastreporttimestamp in __hosts table.
Enable this feature by defining a class in augments (def.json):
{
"classes": {
"cfengine_mp_fr_handle_duplicate_hostkeys": ["any::"]
}
}
Ticket: ENT-6035
Changelog: title
craigcomstock
force-pushed
the
ENT-6035/master
branch
from
6a60d4c to
998c953
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
merge together:
https://github.com/cfengine/nova/pull/1693
#1807
https://github.com/cfengine/system-testing/pull/353