ENT-6375/master: Removed unnecessary packages promises#1846
Merged
nickanderson merged 1 commit intocfengine:masterfrom Oct 14, 2020
Merged
ENT-6375/master: Removed unnecessary packages promises#1846nickanderson merged 1 commit intocfengine:masterfrom
nickanderson merged 1 commit intocfengine:masterfrom
Conversation
nickanderson
changed the title
|
Thanks for submitting a pull request! Maybe @craigcomstock can review this? |
olehermanse
requested changes
Oct 13, 2020
Member
olehermanse
left a comment
olehermanse
left a comment
There was a problem hiding this comment.
LGTM, please squash the squashme commits.
This packages promise was in place to provide package inventory used by packagematching() and packageupdatesmatching() out of the box. This is not needed since ENT-5480 introduced the zypper package module. Ticket: ENT-6375 Changelog: Title
nickanderson
force-pushed
the
ENT-6375/master
branch
from
cd147c9 to
1c2427d
Compare
Member
Author
squashed. |
olehermanse
approved these changes
Oct 13, 2020
Member
Author
|
@cf-bottom jenkins, please. |
|
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/5777/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-5777/ |
Member
Author
|
Failure in jenkins from unrelated tests. One that is known to have stability issues. Merging anyway. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This packages promise was in place to provide package inventory used by
packagematching() and packageupdatesmatching() out of the box. This is not
needed since ENT-5480 introduced the zypper package module.
Ticket: ENT-6375
Changelog: Title