bundle edit_line converge fixups, converge_prepend addition/master#1855
Merged
nickanderson merged 5 commits intocfengine:masterfrom Oct 29, 2020
Merged
Conversation
nickanderson
force-pushed
the
converge_prepend/master
branch
from
0530d7f to
fd51e58
Compare
Contributor
|
YES |
Member
Author
|
@cf-bottom can you please have Jenkins build this since Travis is so epically slow. |
|
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/5892/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-5892/ |
nickanderson
commented
Oct 29, 2020
Member
Author
|
@cf-bottom please run through Jenkins, again. |
|
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/5893/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-5893/ |
Member
Author
|
Alright, @cf-bottom, please run this through Jenkins one more time. |
|
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/5894/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-5894/ |
nickanderson
changed the title
Member
Author
|
Now that's the green I was looking for. |
Ticket: CFE-3483 Changelog: Added bundle edit_line converge_prepend with same behavior as bundle edit_line converge, but inserting at start of content.
nickanderson
force-pushed
the
converge_prepend/master
branch
from
58857f2 to
22a4b87
Compare
In my testing with 3.16, the deletion doesn't work today, so `converge` is not functioning properly. (cherry picked from commit fae4505) Ticket: CFE-3482 Changelog: Title
Ticket: CFE-3482 Changelog: None
nickanderson
force-pushed
the
converge_prepend/master
branch
from
22a4b87 to
845bcc9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Superceeds #1853