ENT-12740: Added more directories that should be deleted to prepare.sh
#3048
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ticket: ENT-12740 Changelog: None
jakub-nt
commented
Sep 29, 2025
| services/autorun/README.md | ||
| templates/README.md | ||
| ci | ||
| modules/mustache |
There was a problem hiding this comment.
Not 100% sure about this one (deleting the entire mustache directory).
There was a problem hiding this comment.
It's empty (only a README), and it's also not present in the tarballs from the website. I think it makes sense to remove here to make the module minimal, and to make it match the tarball. It's the type of thing which should be documented elsewhere (create a folder / file or use this module, or similar).
olehermanse
approved these changes
Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: ENT-12740
Changelog: None