Skip to content

ENT-12740: Added more directories that should be deleted to prepare.sh #3048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 30, 2025
Merged

ENT-12740: Added more directories that should be deleted to prepare.sh #3048

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions prepare.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,8 @@ modules/promises
.no-distrib
services/autorun/README.md
templates/README.md
ci
modules/mustache
Copy link
Contributor Author

@jakub-nt jakub-nt Sep 29, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not 100% sure about this one (deleting the entire mustache directory).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's empty (only a README), and it's also not present in the tarballs from the website. I think it makes sense to remove here to make the module minimal, and to make it match the tarball. It's the type of thing which should be documented elsewhere (create a folder / file or use this module, or similar).


$templates
$(basename $0)
Expand Down