CFE-4623: Fix modules_presence to handle findfiles() trailing slash behavior (3.24)#3125
Merged
Merged
Conversation
…dored without regard to trailing slashes findfiles() behavior was unstable from version 3.21.8 through 3.27.0 and so we needed to refactor this policy to not care whether findfiles() would return directories with trailing slashes or not. The goal of the policy is to find any files in modules/packages which are not in modules/packages/vendored and use those instead of the vendored files. Ticket: CFE-4623 Changelog: none
…ed versions and master (or from source if a core PR is mentioned in the description) Ticket: CFE-4623 Changelog: none
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #3119 to 3.24.x
Refactors the modules_presence bundle to filter out the vendored sub-directory without regard to whether findfiles() returns trailing slashes or not.
This fixes issues caused by the unstable findfiles() behavior from version 3.21.8 through 3.27.0 where trailing slashes were inconsistently returned for directories.
The goal of this policy is to find any files in modules/packages which are not in modules/packages/vendored and use those instead of the vendored files.
Ticket: CFE-4623
Changelog: none