Conversation
No need to send it as a param
And minor cleanup
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor improvement to the way we assign date values in the parser.
Changes
activity_datea property of the parser object. A new parser object is created for each M2 file, and the Activity Date value applies to all records in a Metro2 file, so no specificity is lost.activity_datehas a value (it doesn't when the header segment is missing) and assigns DOAI as activity date when it is missing.Testing
python manage.py testAssigning DOAI as activity date is tested in
test_parser.pyby the test calledtest_parse_file_without_header_line.Checklist