Update Link component story, update unit tests, refactor Link constructor#464
Update Link component story, update unit tests, refactor Link constructor#464flacoman91 merged 17 commits intomainfrom
Conversation
|
|
For the inline links, the dotted underline is missing in the example.
The link text is missing in the list example:
The link shown here is going to a 404 page: Do we need to include this on the documentation page? |
|
For the links stories file can you remove the documentation text for each of the stories? In the DSR we generally include just the component name, the intro from the DS page and a link to the DS page (Source: Link to component page). Other than that, we don't bring in any of the DS documentation content so as to not have to manage it in two places and to keep the CFPB Design System as the source of truth (and the authority on usage guidelines).
Also, can you remove the link on "buttons" in the intro text since we don't want to send users away from the DSR unless they are following that source link directly |
There was a problem hiding this comment.
@flacoman91 - Looks great!
I know we removed the link from "buttons" in the intro text. I thought about it some more and wondered if you think it would be helpful to add it back BUT have the link go to the buttons story within the DSR itself: https://cfpb.github.io/design-system-react/?path=/docs/components-verified-buttons--overview?
|
I don't think it's a big deal to remove it.
We can click the button reference in the sidebar if we need it.
I don't have any strong opinions about it, other than putting a link in
there would prevent someone in the future from updating it to mirror the DS
documentation.
…On Wed, Feb 4, 2026, 8:26 PM Natalia Fitzgerald ***@***.***> wrote:
***@***.**** approved this pull request.
@flacoman91 <https://github.com/flacoman91> - Looks great!
I know we removed the link from "buttons" in the intro text. I thought
about it some more and wondered whether your think it would be helpful to
add it back BUT have the link go to the buttons story within the DSR
itself:
https://cfpb.github.io/design-system-react/?path=/docs/components-verified-buttons--overview
—
Reply to this email directly, view it on GitHub
<#464 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAH5PYVZZIW6NLQXWY4DLJL4KKS35AVCNFSM6AAAAACT5DR2SOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTONJUGE4TGMZTGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@flacoman91 Is the "Link using React Router Link" needed? Asking for my own understanding. What is the use case? |
That example is to let devs know that the DSR Link component is compatible with React Router and we can use our version of the Link component instead of the React Router version We use React Router to define the specific paths for different pages in CCDB and Complaint Explorer such as the data guides and advanced search tips. |
natalia-fitzgerald
left a comment
There was a problem hiding this comment.
@flacoman91 - Looks good!





This PR updates a bunch of linting warnings and updates the storybook story for the Link component
Changes
Breaking changes
How to test this PR
Screenshots
Notes