Skip to content

Add linter script#481

Merged
anselmbradford merged 4 commits intomainfrom
ans_linter
Feb 10, 2026
Merged

Add linter script#481
anselmbradford merged 4 commits intomainfrom
ans_linter

Conversation

@anselmbradford
Copy link
Copy Markdown
Member

@anselmbradford anselmbradford commented Feb 6, 2026

Aligns linter folder structure to that in cfgov and DS

Changes

  • Add linter script
  • Remove legacy http://opensource-checklist.md/
  • Remove run-tsc script

How to test this PR

  1. yarn lint should run (but show many errors).

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 6, 2026

PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-02-10 13:55 UTC

scripts/lint.sh Outdated
yarn prettier "./**/*.{js,jsx,ts,tsx,md,css,less}" --write

## Run JS linting. See ignored path in .eslintignore.
yarn eslint "./**/*.js" --fix
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this also lint ts, tsx files too?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whooops yes!

Copy link
Copy Markdown
Member Author

@anselmbradford anselmbradford Feb 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The old stylelint script only checked .css, but looks like the source files are .scss

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Collaborator

@flacoman91 flacoman91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done. Love the consistency

@anselmbradford anselmbradford added this pull request to the merge queue Feb 7, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Feb 7, 2026
@flacoman91 flacoman91 added this pull request to the merge queue Feb 9, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Feb 9, 2026
@flacoman91 flacoman91 added this pull request to the merge queue Feb 9, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Feb 9, 2026
@anselmbradford anselmbradford added this pull request to the merge queue Feb 10, 2026
@anselmbradford anselmbradford removed this pull request from the merge queue due to the queue being cleared Feb 10, 2026
@anselmbradford anselmbradford merged commit cc9d187 into main Feb 10, 2026
4 checks passed
@anselmbradford anselmbradford deleted the ans_linter branch February 10, 2026 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants